Skip to content

Feature: admin module #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 6, 2015
Merged

Conversation

kingcody
Copy link
Member

Changes:

  • move admin components to admin module
  • use controllerAs syntax for AdminController
  • refactor AdminController, remove unneeded and verbose code
  • use class for AdminController
  • fix and update karma.conf.js (file order, conditionally exclude jade preprocessor)

@kingcody kingcody force-pushed the feature/admin-module branch from 8dc1c1b to f95ace1 Compare September 17, 2015 00:46
@kingcody
Copy link
Member Author

Partially closes #476. I think we should separate the User resource into a user module. Then admin won't have to depend on auth, which should make it very easy to reuse.

@kingcody kingcody added this to the 3.0.0 milestone Sep 17, 2015
@kingcody
Copy link
Member Author

@Awk34 I'll need to rebase this after we merge #1312

@kingcody kingcody force-pushed the feature/admin-module branch from f95ace1 to 618461f Compare September 17, 2015 05:46
Awk34 added a commit that referenced this pull request Oct 6, 2015
@Awk34 Awk34 merged commit 789c64c into angular-fullstack:canary Oct 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants